-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Implement a time service #318
Conversation
5cb3756
to
ee0f1e6
Compare
Implement get_rtc_eventWe need CreateEvent, SignalEvent and ClearEvent syscalls before being able to implement it Lines 125 to 135 in ee0f1e6
This comment was generated by todo based on a
|
Move to FileSystem interface after implementationSunriseOS/time/src/timezone.rs Lines 26 to 36 in ee0f1e6
This comment was generated by todo based on a
|
Use plainSunriseOS/time/src/timezone.rs Lines 250 to 260 in ee0f1e6
This comment was generated by todo based on a
|
Use plainSunriseOS/time/src/timezone.rs Lines 259 to 269 in ee0f1e6
This comment was generated by todo based on a
|
Use plainSunriseOS/time/src/timezone.rs Lines 290 to 300 in ee0f1e6
This comment was generated by todo based on a
|
Use get_rtc_event event handleWe need CreateEvent, SignalEvent and ClearEvent syscalls before using this. SunriseOS/wall-clock/src/main.rs Lines 125 to 135 in ee0f1e6
This comment was generated by todo based on a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few tweaks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the couple of nits about Safety comment format, this looks good!
Also define RTC client interface
Also, make sure to bzero the user buffer before trying timezone conversion.
Also update normalize_overflow documentation.
Also roll back one suggestion as it's not working as intended
Also fix once for all, timezone clearing
6e2906b
to
69ee583
Compare
No one asked for it but here it is: The Civil Time PR!
This PR adds a new process "time" in charge of handling the RTC and Timezones.
Also, The "clock" process was renamed to "wall-clock" and was updated to use the IPC interface accordingly.
PS: This PR needs #317