Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

ClientDevice scan does not work for Modbus address 0 #11

Closed
bobfox opened this issue Apr 7, 2016 · 0 comments
Closed

ClientDevice scan does not work for Modbus address 0 #11

bobfox opened this issue Apr 7, 2016 · 0 comments
Assignees
@shelcrow

Comments

@bobfox
Copy link
Contributor

bobfox commented Apr 7, 2016

The check for a valid SunSpec address fails when the address is 0. Should expand the check to base_addr is not None.
bobfox pushed a commit that referenced this issue Jul 11, 2016
- Corrected scan for Modbus address 0 (issue #11).
abdadd2 
- Corrected excection reporting message (issue #15).
- Updated to optimize writes to multiple sequential Modbus registers.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@shelcrow shelcrow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bobfox @shelcrow