Client.cs patch - Fixes Connect() not returning callback result when the socket isn't null #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Connect() not returning callback result when the socket isn't null.
What kind of change does this PR introduce?
Added
callback?.Invoke(this);
to Connect() in Client.csWhat is the current behavior?
ConnectAync() hangs when Connect() doesn't return a callback result.
Which is also used by supabase-csharp -
client.InitializeAsync();
supabase-community/supabase-csharp#60
What is the new behavior?
Connect() invokes the callback and then returns.
ConnectAync() Doesn't get stuck when the socket isn't null.
Additional context
This issue was introduced in 5.0.2, I believe before the result was created using
TrySetResult()
istead ofSetResult
Callback.