fix: cookie maxAge should be in seconds #765
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @hmnd, this is a non-issue as mentioned in this comment, will be closing the PR but please reopen it if you think that there's still a need for this |
|
@kangmingtay the reason I brought it up is that it causes my Hono app to break. Hono adheres to RFC 6265 and throws when a cookie with a max age > 400 days is set. Would setting to 400 days be a good compromise? |
|
@kangmingtay I don't think I'm able to reopen, but I think this is still an issue for the reason above :) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Cookie maxAge is currently being set to 1000 years, since maxAge is specified in seconds, not milliseconds.
What is the new behavior?
Cookie maxAge is 365 days (1 year), below the maxAge limit of 400 days (https://datatracker.ietf.org/doc/html/draft-ietf-httpbis-rfc6265bis-13#section-4.1.2.2)