Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: smtp config not always enabled #3163

Merged
merged 1 commit into from
Feb 19, 2025
Merged

fix: smtp config not always enabled #3163

merged 1 commit into from
Feb 19, 2025

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Feb 19, 2025

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

The enabled flag is not cloned properly because it's a pointer.

What is the new behavior?

Change to non-pointer and default to true.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner February 19, 2025 10:14
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13410185224

Details

  • 20 of 23 (86.96%) changed or added relevant lines in 3 files are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.05%) to 58.296%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/config/auth.go 16 17 94.12%
pkg/config/config.go 3 5 60.0%
Files with Coverage Reduction New Missed Lines %
pkg/config/auth.go 1 58.2%
internal/storage/rm/rm.go 2 89.53%
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 13392899334: -0.05%
Covered Lines: 7779
Relevant Lines: 13344

💛 - Coveralls

@sweatybridge sweatybridge merged commit 364fd0f into develop Feb 19, 2025
9 checks passed
@sweatybridge sweatybridge deleted the fix-smtp branch February 19, 2025 10:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants