Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: move binary links to npm postinstall lifecycle #712

Merged
merged 3 commits into from
Dec 17, 2022
Merged

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Dec 17, 2022

What kind of change does this PR introduce?

Bug fix #706

What is the new behavior?

  • use postinstall for consistency between npm and yarn
  • link binaries after downloading from github release
  • adds ci check for package installation

Additional context

Add any other context or screenshots.

@coveralls
Copy link

coveralls commented Dec 17, 2022

Pull Request Test Coverage Report for Build 3719682011

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.0%) to 56.335%

Totals Coverage Status
Change from base Build 3713943634: -0.0%
Covered Lines: 3397
Relevant Lines: 6030

💛 - Coveralls

@sweatybridge sweatybridge force-pushed the postinstall branch 3 times, most recently from 89ef46b to 5151679 Compare December 17, 2022 10:46
@sweatybridge sweatybridge merged commit 9eebd04 into main Dec 17, 2022
@sweatybridge sweatybridge deleted the postinstall branch December 17, 2022 12:04
@github-actions
Copy link

🎉 This PR is included in version 1.26.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Operation not permitted error on yarn install command
2 participants