fix: remove client side check of jwt token #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chasers
approved these changes
Jan 21, 2025
filipecabaco
force-pushed
the
fix/remove-jwt-check
branch
5 times, most recently
from
8dfef08 to
c4f13ee
Compare
filipecabaco
force-pushed
the
fix/remove-jwt-check
branch
from
c4f13ee to
407c171
Compare
grdsdev
reviewed
Feb 7, 2025
| tokenToSend && | ||
| channel.updateJoinPayload({ | ||
| access_token: tokenToSend, | ||
| version: VERSION, |
There was a problem hiding this comment.
@filipecabaco instead of sending version, would it be better to send the x-client-info? To differentiate which client is being used?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?