fix: Add write checks to channels #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
filipecabaco
force-pushed
the
fix/write-permission-check-with-rls
branch
from
683070d to
da5f0ba
Compare
chasers
reviewed
Jan 9, 2024
chasers
reviewed
Jan 9, 2024
josevalim
reviewed
Jan 9, 2024
josevalim
reviewed
Jan 9, 2024
josevalim
reviewed
Jan 9, 2024
There was a problem hiding this comment.
Hi @filipecabaco! 👋 I have dropped two comments/questions. :)
abc3
reviewed
Jan 10, 2024
abc3
reviewed
Jan 10, 2024
abc3
reviewed
Jan 10, 2024
abc3
reviewed
Jan 10, 2024
lib/realtime/tenants/repo/migrations/20240108234812_add_channels_column_for_write_check.ex
Outdated
Show resolved
Hide resolved
filipecabaco
force-pushed
the
fix/write-permission-check-with-rls
branch
from
65f58f4 to
c9abe69
Compare
filipecabaco
commented
Jan 11, 2024
Add write permissions checks for the Authorization modules. It checks if a given user can write by trying to updating a column in the channels table. After done, reverts the change within the same transaction. Also took the time to refactor a bit the code to use some helper functions previously built in the Repo module to avoid bare sql code and have a more structured approach.
filipecabaco
force-pushed
the
fix/write-permission-check-with-rls
branch
from
99f2555 to
576dc4e
Compare
abc3
approved these changes
Jan 11, 2024
|
🎉 This PR is included in version 2.25.56 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add write permissions checks for the Authorization modules.
It checks if a given user can write by trying to updating a column in the channels table. After done, reverts the change within the same transaction.
Also took the time to refactor a bit the code to use some helper functions previously built in the Repo module to avoid bare sql code and have a more structured approach.