Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Run migrations on Connect #790

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Conversation

filipecabaco
Copy link
Member

What kind of change does this PR introduce?

Running migrations on Connect will ensure that the tenant database will have the required tables for the new Realtime features. Plus it offloads this concern from the extensions and moves it to the Tenant domain of concerns.

Running migrations on Connect will ensure that the tenant database will have the required
tables for the new Realtime features. Plus it offloads this concern from the extensions and moves
it to the Tenant domain of concerns.
Copy link

vercel bot commented Feb 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
realtime-demo ⬜️ Ignored (Inspect) Visit Preview Feb 23, 2024 7:05pm

@filipecabaco filipecabaco requested review from chasers, abc3, w3b6x9 and a team February 23, 2024 18:34
This will ensure that we won't fall into an issue where users can connect and have
a db connection but when they check authorization they will get an error since
the migrations might not have run at that point in time
Copy link

@philss philss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chasers
Copy link
Contributor

chasers commented Feb 26, 2024

Me too!!

@filipecabaco filipecabaco merged commit 7d3c388 into main Feb 26, 2024
4 checks passed
@filipecabaco filipecabaco deleted the fix/migrations-run-on-connect branch February 26, 2024 17:53
@kiwicopple
Copy link
Member

🎉 This PR is included in version 2.25.67 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants