Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: default 5GB limit as max-file size #616

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

fenos
Copy link
Contributor

@fenos fenos commented Jan 13, 2025

What kind of change does this PR introduce?

Bug fix

What is the new behavior?

Modifying the default (10MB) of fastify multipart to 5GB as the maximum limit accepted.
Downstream we have the right file size validation

@coveralls
Copy link

coveralls commented Jan 13, 2025

Pull Request Test Coverage Report for Build 12765612079

Details

  • 22 of 26 (84.62%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 78.038%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/http/routes/s3/commands/put-object.ts 21 25 84.0%
Totals Coverage Status
Change from base Build 12748509668: 0.05%
Covered Lines: 14258
Relevant Lines: 18119

💛 - Coveralls

@fenos fenos force-pushed the fix/default-max-file-size-s3-post-upload branch from 49e0b51 to 668337a Compare January 14, 2025 10:21
@fenos fenos merged commit 360a04b into master Jan 14, 2025
1 check passed
@fenos fenos deleted the fix/default-max-file-size-s3-post-upload branch January 14, 2025 10:28
Copy link

🎉 This PR is included in version 1.16.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants