-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: Pre-Signed URL Signatures with Storage JWT Secret #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
570505b
to
71ffda7
Compare
Pull Request Test Coverage Report for Build 14273943858Details
💛 - Coveralls |
hf
reviewed
Apr 2, 2025
fenos
reviewed
Apr 2, 2025
fenos
reviewed
Apr 2, 2025
fenos
reviewed
Apr 2, 2025
fenos
reviewed
Apr 2, 2025
fenos
reviewed
Apr 2, 2025
fenos
reviewed
Apr 2, 2025
fenos
reviewed
Apr 2, 2025
fenos
reviewed
Apr 2, 2025
fenos
requested changes
Apr 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great!
Just left some questions / small improvements to consider improving
itslenny
commented
Apr 2, 2025
itslenny
commented
Apr 2, 2025
98d0405
to
d4f445c
Compare
fenos
reviewed
Apr 4, 2025
fenos
reviewed
Apr 4, 2025
fenos
reviewed
Apr 4, 2025
8d5d6e5
to
ca6564f
Compare
ca6564f
to
a29b76d
Compare
1b40e11
to
cb22a61
Compare
fenos
approved these changes
Apr 8, 2025
🎉 This PR is included in version 1.21.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
What is the current behavior?
URLs can only be signed using the tenant jwt secret associated with the project
What is the new behavior?