-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: Purge cache for specific objects #650
Conversation
⛔ Snyk checks have failed. 2 issues have been found so far.
⛔ code/snyk check is complete. 2 issues have been found. (View Details) 💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
15c42e0
to
2c01e2c
Compare
Pull Request Test Coverage Report for Build 14262662188Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 14218413363Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Maybe resolve those eslint warnings.
edit: I saw the warnings in "files changed" tab, but didn't realize this wasn't actually part of the change. Removing (e: any)
if it's not going to be used should resolve both warnings (config.ts:462).
e0f8d9d
to
a03cfaa
Compare
a03cfaa
to
1a32426
Compare
🎉 This PR is included in version 1.20.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
What kind of change does this PR introduce?
Feature
What is the current behavior?
Currently is not possible to purge the cache programmatically
What is the new behavior?
This PR introduces a new endpoint:
DELETE /cdn/{bucket}/{object}
that allows purging the cache for a specific objectAdditional context
The actual implementation for purging the cache sits outside of storage, this is because we don't want to couple the service
to a specific purge mechanism.
Storage invokes an external HTTP endpoint, which does the purging to keep it agnostic