-
-
Notifications
You must be signed in to change notification settings - Fork 218
feat: Initialize supabase with custom websocket client #1145
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: main
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 15667650391Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
@Vinzent03 we should make sure we run CI also on macOS, and test the package at least in a iOS build, just saw that we don't to that. I created an issue for tracking that, #1146 feel free to pick it if you want, otherwise I can work on it later. |
I'm pretty sure to verify the behavior of the cupertino http client we can't just run the existing ci on a macos build in ci. For iOS we need flutter integration tests to actually run them on a iOS simulator. For macOS I'm unsure if the cupertino http client works if we run widget tests or actually need integratino tests as well. So we would need to write many additional tests sa well. |
I see there is an Probably just getting all these examples built in CI, would already solve the issue with checking if the library works on all available platforms. |
Hey @Vinzent03 I just merged a few changes to CI, including builds on the macOS runner, can you rebase this PR? |
I think I could get this pr working, but (with the weird error on macos now as well) I'm unsure we really want this pr to land. I think one huge benefit of the supabase packages is the lack of native dependencies, unlike firebase. So the building is a lot let stressful. We already see some supabase unrelated issues because of app_links and its native part. Since one can already replace the http client, I think it's a better and more composable implementation to allow a custom websocket client in |
Big fan of just writing a quick example for others to use. |
+1 on Dan here. |
@dshukertjr Do we want the documentation on how to integrate the cupertino/cronet http/websocket clients in the readme or on the docs website with a link to that in the readme? The required changes I would note are:
|
What kind of change does this PR introduce?
feature
What is the current behavior?
Uses the implementation from
dart:io
forhttp.Client
andWebSocketChannel
.What is the new behavior?
Use the classes provided by
cupertino_http
.Additional context
I do not own a mac, so I cannot test this. So we can hopefully find a person to verify this actually works on iOS and macOS.
close #147