-
-
Notifications
You must be signed in to change notification settings - Fork 267
fix: use requests for upload (Sourcery refactored) #122
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: use requests for upload (Sourcery refactored) #122
Conversation
public_url = f"{self.url}/object/public/{_path}" | ||
return public_url | ||
return f"{self.url}/object/public/{_path}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function StorageFileAPI.get_public_url
refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable
)
body["prefix"] = path if path else "" | ||
body["prefix"] = path or "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function StorageFileAPI.list
refactored with the following changes:
- Simplify if expression by using or (
or-if-exp-identity
)
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.03%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Codecov Report
@@ Coverage Diff @@
## fix/use-requests-for-upload #122 +/- ##
===============================================================
+ Coverage 50.35% 50.53% +0.17%
===============================================================
Files 9 9
Lines 284 283 -1
===============================================================
Hits 143 143
+ Misses 141 140 -1
Continue to review full report at Codecov.
|
Pull Request #121 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
fix/use-requests-for-upload
branch, then run:Help us improve this pull request!