Custom exception class, URL & Key validation using RegEx, typo fixes.

[rawandahmad698]

What kind of change does this PR introduce?

Creates a custom exception class for easier debugging. Fixes some typos, Adds URL & Key validation using RegEx

What is the current behavior?

Currently, Exception and BaseException are thrown, which can make your code prone to errors and difficult to maintain

What is the new behavior?

Adds a custom exception class.

[sourcery-ai]

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 1.81%.

Quality metrics	Before	After	Change
Complexity	1.35 ⭐	1.99 ⭐	0.64 👎
Method Length	45.38 ⭐	45.23 ⭐	-0.15 👍
Working memory	7.67 🙂	7.95 🙂	0.28 👎
Quality	76.00% ⭐	74.19% 🙂	-1.81% 👎

Other metrics	Before	After	Change
Lines	273	288	15

Changed files	Quality Before	Quality After	Quality Change
supabase/client.py	69.93% 🙂	67.98% 🙂	-1.95% 👎
supabase/lib/auth_client.py	64.67% 🙂	64.67% 🙂	0.00%
supabase/lib/realtime_client.py	83.67% ⭐	83.67% ⭐	0.00%
tests/test_client.py	83.21% ⭐	83.21% ⭐	0.00%
tests/test_function_configuration.py	84.14% ⭐	81.36% ⭐	-2.78% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
supabase/client.py	Client.__init__	6 ⭐	212 ⛔	15 😞	43.73% 😞	Try splitting into smaller methods. Extract out complex expressions
supabase/lib/auth_client.py	SupabaseAuthClient.__init__	0 ⭐	68 🙂	16 ⛔	64.67% 🙂	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

[mansueli]

This merge is failing because of the test on:

https://github.com/supabase-community/supabase-py/blob/develop/tests/test_function_configuration.py

Could you rewrite the test there @rawandahmad698, so it passes the test?
It looks really good otherwise.

[rawandahmad698]

Yessir I can

…

On Fri, Oct 21, 2022 at 3:51 PM Rodrigo Mansueli Nunes < ***@***.***> wrote: This merge is failing because of the test on: https://github.com/supabase-community/supabase-py/blob/develop/tests/test_function_configuration.py Could you rewrite the test there @rawandahmad698 <https://github.com/rawandahmad698>, so it passes the test? It looks really good otherwise. — Reply to this email directly, view it on GitHub <#289 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEUB6W5PNTLBHCWZGK5LETDWEKGWNANCNFSM6AAAAAARHJBYQE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[rawandahmad698]

@mansueli Fixed

[J0]

Hey @rawandahmad698

Thanks for this PR! We're almost at the point we can merge -- seems like the tests are failing as the pre-commit hook (black) hasn't run.

Do you mind running the necessary formatters over the code so that the tests pass?

[rawandahmad698]

Hey @rawandahmad698

Thanks for this PR! We're almost at the point we can merge -- seems like the tests are failing as the pre-commit hook (black) hasn't run.

Do you mind running the necessary formatters over the code so that the tests pass?

Could you please clarify? All the tests are OK on my end.

[J0]

So that CI passes* you can take a look at the CI checks for 8244244

You might want to run poetry run pre-commit run --all-files to run the necessary formatting checks

[rawandahmad698]

So that CI passes* you can take a look at the CI checks for 8244244

You might want to run poetry run pre-commit run --all-files to run the necessary formatting checks

All good, thank you
trim trailing whitespace.................................................Passed
check for added large files..............................................Passed
fix end of files.........................................................Passed
mixed line ending........................................................Passed
isort....................................................................Passed
autoflake................................................................Passed
black....................................................................Passed
pyupgrade................................................................Passed

[J0]

Hey @rawandahmad698 yup it looks perfect now,

Thanks for your patience with us and we appreciate your effort on this PR!
Do let us know if there's anything else that we can help you with

[rawandahmad698]

Appreciate your help, will continue opening PR's :)