Skip to content

chore: publish v1.0.0 with new versions of sublibs. py37 is deprecated #360

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 8 commits into from
Feb 5, 2023

Conversation

J0
Copy link
Contributor

@J0 J0 commented Feb 5, 2023

See title

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 5, 2023

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.91%.

Quality metrics Before After Change
Complexity 3.05 ⭐ 2.98 ⭐ -0.07 👍
Method Length 46.50 ⭐ 44.14 ⭐ -2.36 👍
Working memory 9.04 🙂 8.76 🙂 -0.28 👍
Quality 70.44% 🙂 71.35% 🙂 0.91% 👍
Other metrics Before After Change
Lines 293 289 -4
Changed files Quality Before Quality After Quality Change
supabase/__version__.py 100.00% ⭐ 100.00% ⭐ 0.00%
supabase/client.py 67.98% 🙂 67.98% 🙂 0.00%
supabase/lib/auth_client.py 64.67% 🙂 85.63% ⭐ 20.96% 👍
supabase/lib/client_options.py 58.59% 🙂 58.59% 🙂 0.00%
tests/test_client_options.py 86.62% ⭐ 86.62% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
supabase/client.py Client.__init__ 6 ⭐ 212 ⛔ 15 😞 43.73% 😞 Try splitting into smaller methods. Extract out complex expressions
supabase/lib/client_options.py ClientOptions.replace 8 ⭐ 110 🙂 12 😞 56.18% 🙂 Extract out complex expressions
supabase/lib/auth_client.py SupabaseAuthClient.__init__ 0 ⭐ 58 ⭐ 12 😞 71.59% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Feb 5, 2023

Codecov Report

Base: 78.98% // Head: 78.75% // Decreases project coverage by -0.24% ⚠️

Coverage data is based on head (f389e77) compared to base (e62e95d).
Patch coverage: 88.88% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #360      +/-   ##
===========================================
- Coverage    78.98%   78.75%   -0.24%     
===========================================
  Files            9        9              
  Lines          157      160       +3     
===========================================
+ Hits           124      126       +2     
- Misses          33       34       +1     
Impacted Files Coverage Δ
supabase/client.py 91.80% <ø> (ø)
supabase/lib/auth_client.py 88.88% <83.33%> (-11.12%) ⬇️
supabase/__version__.py 100.00% <100.00%> (ø)
supabase/lib/client_options.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@J0 J0 merged commit 1cd6d87 into develop Feb 5, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant