feat: execute event triggers under superuser #115
+404
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes supabase#110. superuser evtrigs now work as usual with the exception of `CREATE EXTENSION`. Which will now fire superuser evtrigs, but not regular user evtrigs. This is because how `CREATE EXTENSION` works under supautils (switchs to superuser before executing CREATE EXTENSION).
Pull Request Test Coverage Report for Build 13465900268Details
💛 - Coveralls |
soedirgo
reviewed
Feb 24, 2025
|
|
||
| if(!current_user_is_super && function_is_owned_by_super){ | ||
| ereport(ERROR, ( | ||
| errmsg("supautils requires a non-superuser event trigger to execute a non-superuser owned function") |
There was a problem hiding this comment.
Nit: users shouldn't need to know what "supautils" is
Suggested change
| errmsg("supautils requires a non-superuser event trigger to execute a non-superuser owned function") | |
| errmsg("Non-superuser owned event trigger must execute a non-superuser owned function") |
soedirgo
reviewed
Feb 24, 2025
|
|
||
| if(current_user_is_super && !function_is_owned_by_super){ | ||
| ereport(ERROR, ( | ||
| errmsg("supautils requires a superuser event trigger to execute a superuser owned function") |
There was a problem hiding this comment.
Suggested change
| errmsg("supautils requires a superuser event trigger to execute a superuser owned function") | |
| errmsg("Superuser owned event trigger must execute a superuser owned function") |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #110.
superuser evtrigs now work as usual with the exception of
CREATE EXTENSION. Which will now fire superuser evtrigs, but not regular user evtrigs.This is because how
CREATE EXTENSIONworks under supautils (switchs to superuser before executing CREATE EXTENSION).