-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Compression test #106
Open
mcclearyj
wants to merge
28
commits into
master
Choose a base branch
from
compression_test
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Compression test #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds infrastructure necessary to produce MEDS files similar to those expected during flight. Changes include:
medsmaker
now includes a quick-reduce function that can accommodate median dark subtraction and a flat-field correction (right now there's none but the attribute exists).medsmaker_mocks.py
makes a combined BPM+master_dark mask, similar to the one planned for OBA doc (ref)TAN
fromTPV
. Since PIFF knows how to handle TAN (but not TPV), PIFF can be now run on the coadd and its PSF included in the MEDS ifuse_coadd=True
. This should address Figure out what placeholder to put in the coadd PSF image #83Known issues:
meds
package multiplies image cutouts by a floating-point value before saving a MEDS,int16
-format images cannot be saved. Doing so will require modification of a few lines in themeds/maker.py
code here.meds
expects masks with the "0==good, 1==bad" convention. As a workaround, a mask is saved in each format.