Created ISandbox and move implementation to node #335
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds interface for Sandbox. Which is then implemented in node.
All core uses
PureJSSandbox
(which isn't sandbox), to evaluate comlink script.What I am missing is testing Sandboxes that they interpret scripts in the same way, so we can really keep using PureJSSandbox in core.
Motivation and Context
This will allows us to use different ways for sandboxing and in corner cases disable it entirely.
Types of changes
Checklist: