Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Created ISandbox and move implementation to node #335

Merged
merged 4 commits into from
Feb 24, 2023
Merged

Conversation

freaz
Copy link
Member

@freaz freaz commented Feb 16, 2023

Description

This adds interface for Sandbox. Which is then implemented in node.

All core uses PureJSSandbox (which isn't sandbox), to evaluate comlink script.

What I am missing is testing Sandboxes that they interpret scripts in the same way, so we can really keep using PureJSSandbox in core.

Motivation and Context

This will allows us to use different ways for sandboxing and in corner cases disable it entirely.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have updated the documentation accordingly. If you are changing code related to user secrets you need to really make sure that security documentation is correct.
  • I have read the CONTRIBUTING document.
  • I haven't repeated the code. (DRY)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@freaz freaz force-pushed the refactor/isandbox branch from 5c0cbbb to 7a8b170 Compare February 16, 2023 15:50
@freaz freaz changed the title Create ISandbox and move implementation to node Created ISandbox and move implementation to node Feb 16, 2023
@freaz freaz force-pushed the refactor/isandbox branch from cfb272a to 238e984 Compare February 17, 2023 12:47
@freaz freaz requested a review from TheEdward162 February 17, 2023 12:49
@freaz freaz force-pushed the refactor/isandbox branch from 238e984 to 8511323 Compare February 17, 2023 12:56
@freaz freaz marked this pull request as ready for review February 17, 2023 12:59
@freaz freaz merged commit 15cb232 into main Feb 24, 2023
@freaz freaz deleted the refactor/isandbox branch February 24, 2023 06:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants