feat(chat/messages): Implement retrieving thread messages #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add `listThreadMessages` boolean to enable slack map list thread messages - add `threadId` string to pass in thread destination
- implement retrieving thread messages for slack map - make discord map compatible with same format of input parameters as slack map - filter parent messages of threads when listing thread messages
jnv
suggested changes
Mar 25, 2022
There was a problem hiding this comment.
TBH I think this approach is flawed, but maybe I misunderstand the context
listThreadMessagesseems redundant since it always needs to be set together withthreadId- But maybe it is needed and I can set
threadIdwithlistThreadMessages = false? - Would it make sense to put this rather into a separate use case?
| @@ -3,7 +3,7 @@ Chat Messages | |||
| Retrieve chat messages. | |||
| """ | |||
| name = "chat/messages" | |||
| version = "1.0.0" | |||
There was a problem hiding this comment.
Additional properties are minor version change (new features).
|
Discord is able to get thread messages passing threadId as destination but slack has to specify thread id along with it which is not required in profile. I can create new use-case for it which would remove |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extends use-case
GetMessagesin profilechat/messageswith new fields:listThreadMessages: boolean that represents whether to list messages from channel or thread destination.threadId: string that represents thread idMotivation and Context
Implement getting thread messages for slack.
Types of changes
Checklist: