Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: concurrent map writes error and version bump #430

Merged
merged 5 commits into from
Sep 25, 2024

Conversation

deepjyoti30-st
Copy link
Contributor

@deepjyoti30-st deepjyoti30-st commented Sep 25, 2024

Summary of change

  • Fixes dashboard crashing on refresh (due to user GET API making the SDK crash)
  • Bumps version to 0.25.0

Test Plan

Example go app with dashboard recipe should not crash on refreshes.

Jam showing the main fix in action

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens/constants.go
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In supertokens/constants.go > version variable
  • Had installed and ran the pre-commit hook
  • If new thirdparty provider is added,
    • update switch statement in recipe/thirdparty/providers/config_utils.go file, createProvider function.
    • add an icon on the user management dashboard.
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If access token structure has changed
    • Modified test in session/accessTokenVersions_test.go to account for any new claims that are optional or omitted by the core

@deepjyoti30-st deepjyoti30-st changed the title Fix: concurrent map writes error and version bump fix: concurrent map writes error and version bump Sep 25, 2024
@rishabhpoddar rishabhpoddar merged commit 08844a5 into 0.25 Sep 25, 2024
6 of 11 checks passed
@rishabhpoddar rishabhpoddar deleted the fix/concurrent-map-writes-err-and-version-bump branch September 25, 2024 08:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants