Fix: Resolve potential deadlock in suspended actor scenario. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
cloudmark
commented
Jun 15, 2024
cloudmark
commented
- Updated documentation for clarity.
- Removed dependency on RabbitMQ.
- Updated documentation for clarity. - Removed dependency on RabbitMQ.
jducoeur
reviewed
Jun 15, 2024
|
|
||
| libraryDependencies += "com.github.suprnation" % "cats-actors_2.13" % "1.0.0" | ||
| libraryDependencies += "com.github.suprnation" % "cats-actors" % "1.0.2" |
There was a problem hiding this comment.
I think this should be
libraryDependencies += "com.github.suprnation" %% "cats-actors" % "1.0.2"
(Experienced Scala devs wouldn't even blink at it, but relative newbies often stumble on this sort of thing, so I'm sensitive to it.)
There was a problem hiding this comment.
Agree. Will fix this shortly.
PetrosPapapa
referenced
this pull request
in PetrosPapapa/cats-actors
Aug 21, 2024
Added tests for DeathWatch watch. Fixed issue with reference actor in watcher tracker and removed override of watch/unwatch in ActorCell to let the DeathWatch handle it.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.