Add a request macro #1
Conversation
This adds a request macro that can be used to transform the underlying request data.
|
Hi, Thanks for making a PR for this. I was planning to eventually write out a provider to integrate better with the framework. The macro on the request is a great idea. Ill give this a further review and test this later this afternoon/evening. |
| Transformer::unguard(); | ||
| // This is kind of a dirty way to add the macro | ||
| // without including orchestra/testbench | ||
| (new \Surgiie\Transformer\TransformerServiceProvider('')) |
There was a problem hiding this comment.
Im okay with this for now since we're still able to test the functionality of the package without orchestra/testbench. Will leave it as a future consideration to pull in orchestra/testbench if the package grows to the point where functionality cannot be tested without it.
| Request::macro('transform', function (array $input, array $transformers = null): array { | ||
| $localTransformers = $transformers ?? $input; | ||
| $input = is_null($transformers) | ||
| ? (method_exists($this, 'validated') |
There was a problem hiding this comment.
I think using validated if the request object is a FormRequest is okay but does have a silent omission of transformation if a validation rule is not defined in the form request. Example:
If you do something like: $formRequest->transform(['name' => 'trim|ucfirst'])
but dont have a rule defined in the form request, i.e:
public function rules(){
return [
'name'=>['...']
];
}That data is not transformed, and it will not be present in the transformed data array returned from transform which may cause some confusion, however I think im okay with this for now and just pointing it out, Ill make a note of this on the README in a future commit.
There was a problem hiding this comment.
Yes that's a valid point. It's a bit presumptuous.
|
This has been released in v0.2.0. |
This adds a request macro that can be used to transform the underlying request data. It cuts out some of the extra syntax and transforms the request data.
If you choose to merge this, it would be super helpful for you to add the
hacktoberfest-acceptedtag!