Implement the Center pivot point for rectangle #198

Antonio-Bennett · 2021-10-01T06:19:53Z

This pull request fixes #193

suspistew · 2021-10-02T16:04:16Z

Hey @Antonio-Bennett you're almost there, but there is one more thing :

To compute the center position of a rectangle, we need an x offset and an y offset. That's different from the square because a rectangle can have different width/height

Can you do this please ?

Antonio-Bennett · 2021-10-02T16:06:12Z

Ahh yes that makes sense actually, ok not at home at the moment but will do this later 🙂

Antonio-Bennett · 2021-10-03T02:07:19Z

Ok I've made some changes tell me if I still need to fix anything :) thanks for being patient

suspistew · 2021-10-03T06:28:26Z

hey @Antonio-Bennett, perfect, thanks ! No problem, these issues are here to 'learn' and be patient !

Please consider giving a little ⭐ for the project if you don't mind, it helps it to be visible in the community. 🙏

Antonio-Bennett · 2021-10-03T14:02:30Z

Yup for sure ⭐️! Loving the rust community so far!

Antonio-Bennett added 2 commits October 1, 2021 02:11

created new_with_offset function which is called in Pivot function

52dc66d

change the new function to use new_with_offset function

78f81a1

Antonio-Bennett mentioned this pull request Oct 1, 2021

Implement the Center pivot point for rectangle #193

Closed

fix offset function to have both x and y offsets

aeb6c6a

suspistew merged commit c5aec99 into suspistew:main Oct 3, 2021

Provide feedback