-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[CI] update CI to keep same with github action template #5
Conversation
SamYuan1990
commented
Dec 20, 2023
•
edited
Loading
edited
- update CI with ci.yml as before and after PR level check, make it same with our example in readme document to keep user's input been tested with our CI.
- decouple a PR image build and publish process with before and after PR check.
- fix lint issue
- fix action input define issue
- fix action output define issue.
ff6d8a0
to
4ad6974
Compare
Signed-off-by: Sam Yuan <yy19902439@126.com>
835ce78
to
f0073b1
Compare
Signed-off-by: Sam Yuan <yy19902439@126.com>
Signed-off-by: Sam Yuan <yy19902439@126.com>
@rootfs , to keep the same usage for user and CI, we have to follow https://github.com/actions/hello-world-docker-action/blob/main/.github/workflows/ci.yml#L65-L69 to set up CI for this repo instead of just |
Signed-off-by: Sam Yuan <yy19902439@126.com>
ok I got lint issue been fixed. |
Signed-off-by: Sam Yuan <yy19902439@126.com>
but https://github.com/sustainable-computing-io/aws_ec2_self_hosted_runner/actions/runs/7276748449/job/19827220326?pr=5 security group id is still missing. |
@rootfs , could you please help check secret settings for https://github.com/sustainable-computing-io/aws_ec2_self_hosted_runner/actions/runs/7276748449/job/19827220326?pr=5#step:1:20 |
Anyone with collaborator access to this repository can use these secrets and variables for actions. They are not passed to workflows that are triggered by a pull request from a fork. .... |
@SamYuan1990 can you check the test errors? The docker action has its own env var naming convention, all the input parameters must start with |
I suppose the difference is between https://github.com/sustainable-computing-io/aws_ec2_self_hosted_runner/actions/runs/7225181901/job/19688062061#step:1:20 and https://github.com/sustainable-computing-io/aws_ec2_self_hosted_runner/actions/runs/7276748449/job/19827220326?pr=5#step:1:20 |
close this as this will not works due to github action security setting, switch to #6 |