Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[CI] update CI to keep same with github action template #5

Closed

Conversation

SamYuan1990
Copy link
Contributor

@SamYuan1990 SamYuan1990 commented Dec 20, 2023

  1. update CI with ci.yml as before and after PR level check, make it same with our example in readme document to keep user's input been tested with our CI.
  2. decouple a PR image build and publish process with before and after PR check.
  3. fix lint issue
  4. fix action input define issue
  5. fix action output define issue.

@SamYuan1990 SamYuan1990 requested a review from a team as a code owner December 20, 2023 13:41
@SamYuan1990 SamYuan1990 marked this pull request as draft December 20, 2023 13:45
Signed-off-by: Sam Yuan <yy19902439@126.com>
Signed-off-by: Sam Yuan <yy19902439@126.com>
Signed-off-by: Sam Yuan <yy19902439@126.com>
Signed-off-by: Sam Yuan <yy19902439@126.com>
Signed-off-by: Sam Yuan <yy19902439@126.com>
@SamYuan1990 SamYuan1990 requested a review from rootfs December 20, 2023 14:17
@SamYuan1990 SamYuan1990 marked this pull request as ready for review December 20, 2023 14:17
@SamYuan1990
Copy link
Contributor Author

SamYuan1990 commented Dec 20, 2023

@rootfs , to keep the same usage for user and CI, we have to follow https://github.com/actions/hello-world-docker-action/blob/main/.github/workflows/ci.yml#L65-L69 to set up CI for this repo instead of just docker run ... hence I made this PR and try to fix some issues found today. could you please help check with https://github.com/sustainable-computing-io/aws_ec2_self_hosted_runner/actions/runs/7276748449/job/19827220326?pr=5 I am confused a little for why the secrets.AWS_SECURITY_GROUP_ID is missing.

Signed-off-by: Sam Yuan <yy19902439@126.com>
@SamYuan1990
Copy link
Contributor Author

ok I got lint issue been fixed.

Signed-off-by: Sam Yuan <yy19902439@126.com>
@SamYuan1990
Copy link
Contributor Author

@SamYuan1990
Copy link
Contributor Author

@SamYuan1990
Copy link
Contributor Author

Anyone with collaborator access to this repository can use these secrets and variables for actions. They are not passed to workflows that are triggered by a pull request from a fork. ....

@rootfs
Copy link
Contributor

rootfs commented Dec 21, 2023

@SamYuan1990 can you check the test errors? The docker action has its own env var naming convention, all the input parameters must start with INPUT_ (see here), and the script convert the INPUT_ env var to its own internal names (see here)

@SamYuan1990
Copy link
Contributor Author

@SamYuan1990 can you check the test errors? The docker action has its own env var naming convention, all the input parameters must start with INPUT_ (see here), and the script convert the INPUT_ env var to its own internal names (see here)

I suppose the difference is between https://github.com/sustainable-computing-io/aws_ec2_self_hosted_runner/actions/runs/7225181901/job/19688062061#step:1:20 and https://github.com/sustainable-computing-io/aws_ec2_self_hosted_runner/actions/runs/7276748449/job/19827220326?pr=5#step:1:20
as we can see the Secret source are different. let me try to verify via another PR.

Signed-off-by: Sam Yuan <yy19902439@126.com>
@SamYuan1990
Copy link
Contributor Author

close this as this will not works due to github action security setting, switch to #6

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants