Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

acme/autocert: missing server name #36

Closed
1722393429 opened this issue Mar 2, 2022 · 10 comments
Closed

acme/autocert: missing server name #36

1722393429 opened this issue Mar 2, 2022 · 10 comments

Comments

@1722393429
Copy link

2022/03/02 20:26:18 http: TLS handshake error from 138.246.253.24:41988: acme/autocert: missing server name

@tcwalther
Copy link

While this issue has little information about the problem, I can confirm that letsencrypt integration seems to be broken. It used to work flawlessly less than a year ago, but when I run ssl-proxy with -domain=example.com now, I get the same error message. Using a manual cert+key pair (created via certbot) works fine.

@suyashkumar
Copy link
Owner

Thanks for reporting this folks! I'll take a look at this this weekend. Out of curiosity, does this happen with the prebuilt binaries and also when you build from source?

@grischard
Copy link

grischard commented Mar 9, 2022

Hi! This happens to me both when I build from source (linux, aarm64) and with the pre-built binaries (darwin, amd64).

I run:

./ssl-proxy-darwin-amd64 -from [::]:443 -to 127.0.0.1:8000 -domain reasonableexcuse.stereo.lu

The logs say:

2022/03/08 19:51:03 http: TLS handshake error from [2001:470:1f07:63c:8cc:74b8:1f3:1009]:52731: acme/autocert: unable to satisfy "https://acme-v02.api.letsencrypt.org/acme/authz-v3/85721842810" for domain "reasonableexcuse.stereo.lu": no viable challenge type found
2022/03/08 19:51:04 http: TLS handshake error from [2001:470:1f07:63c:8cc:74b8:1f3:1009]:52734: acme/autocert: missing certificate

@suyashkumar
Copy link
Owner

Thanks folks! I think that I've been able to repro and fix the error in a limited test environment, simply by updating the golang crypto dependencies. Sending a PR here: #37 that should be merged soon. Thanks for reporting, and if you get a chance to test it let me know if it worked in your usage. Thanks!

suyashkumar added a commit that referenced this issue Mar 9, 2022
… Go modules (#37)

This should address #36 primarily by updating the golang.org/x/crypto dependency. In order to address some other GitHub actions blockers, we also update the GitHub Actions config and update to go1.17.
@suyashkumar
Copy link
Owner

suyashkumar commented Mar 9, 2022

This should be addressed with #37, and I've also published an updated release with prebuilt binaries here: https://github.com/suyashkumar/ssl-proxy/releases/tag/v0.2.7

You can easily pull down the latest release at the command line with

wget -qO- "https://getbin.io/suyashkumar/ssl-proxy" | tar xvz 

Give them a try and let me know if you still have issues. Thanks!

@Jipok
Copy link

Jipok commented Mar 10, 2022

Fixed for me.

@suyashkumar
Copy link
Owner

Great! I'll close this out then. If anyone else has similar issues feel free to comment and reopen. Thanks!

@mxbfnk
Copy link

mxbfnk commented Feb 18, 2024

Heyja, I think the problem is present again with newest version 0.5.2.

Connecting from WIN Agent to Linux Proxy.

-selfcert works fine!

@grischard
Copy link

@mxbfnk Since this issue is two years old and the original cause of that problem got resolved, can I suggest opening a new issue?

@mxbfnk
Copy link

mxbfnk commented Feb 18, 2024

sure. ;) I thought here because of the last comment from @suyashkumar

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants