-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comparison of FENDL3.2b with FENDL2.0 for select isotopes and reactions. #70
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find a specific code change to suggest (not enough time/attention) but the threshold reactions are at the wrong energy, probably because of the order in which you prepend with 0 and then assign the energies. I think the simple solution may be just to append with 0 instead of prepending.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I proposed specific changes for the prepend that I think will make all the threshold reactions look better
def prepend_with_zeros(cross_sections): | ||
""" | ||
Include zeroes into the beginning of a list such that the total length of | ||
of the list is 175, corresponding to the Vitamin-J group structure. | ||
|
||
Arguments: | ||
cross_sections (list): List of cross sections, of length less than or | ||
equal to 175. | ||
|
||
Returns: | ||
cross_sections (list): Potentially modified list of cross sections, with | ||
zeroes prepended to bring the length of the list to 175. | ||
""" | ||
|
||
current_length = len(cross_sections) | ||
zeros_needed = 175 - current_length | ||
cross_sections = [0] * zeros_needed + cross_sections | ||
|
||
return cross_sections |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should append:
def prepend_with_zeros(cross_sections): | |
""" | |
Include zeroes into the beginning of a list such that the total length of | |
of the list is 175, corresponding to the Vitamin-J group structure. | |
Arguments: | |
cross_sections (list): List of cross sections, of length less than or | |
equal to 175. | |
Returns: | |
cross_sections (list): Potentially modified list of cross sections, with | |
zeroes prepended to bring the length of the list to 175. | |
""" | |
current_length = len(cross_sections) | |
zeros_needed = 175 - current_length | |
cross_sections = [0] * zeros_needed + cross_sections | |
return cross_sections | |
def append_with_zeros(cross_sections): | |
""" | |
Include zeroes into the end of a list such that the total length of | |
of the list is 175, corresponding to the Vitamin-J group structure. | |
Arguments: | |
cross_sections (list): List of cross sections, of length less than or | |
equal to 175. | |
Returns: | |
cross_sections (list): Potentially modified list of cross sections, with | |
zeroes appended to bring the length of the list to 175. | |
""" | |
current_length = len(cross_sections) | |
zeros_needed = 175 - current_length | |
cross_sections = cross_sections + [0] * zeros_needed | |
return cross_sections |
I wonder if @bohmt has any thoughts on these cross-section comparison plots? |
@gonuke, and @eitan-weinstein, you may have discussed this while I was out, but I'm not a fan of adding nuclear data and plots (binary data) to git due to bloating the repo, and the principle of git is for "inputs" not "outputs". As for the plots:
|
Includes a python script that processes cross section data from FENDL3.2b and FENDL2.0 for a specific isotope and reaction to plot the cross sections over each other against the 175 energy groups in the Vitamin-J structure. Additionally, a number of example cases are included.