-
Notifications
You must be signed in to change notification settings - Fork 45
Drop Node 10 and 12. Upgrade to eslint 8 #178
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
@benmccann @dummdidumm Do you think we also want to bump the peerdep of ESLint to 8+? I would think so, but I wanted to get other opinions, since it wasn't included in this PR. |
I don't have much of an opinion one way or the other. The one thing to possibly check would be whether eslint 8 is compatible with older versions of Node and would run on sveltejs/svelte repo if there's a concern about being able to run the latest version of this plugin on that repo |
I just bumped the peerdep version. I sent sveltejs/svelte#7506 which shows eslint 8 works just fine on older versions of node. I also noticed the |
If we're saying the peerdep is ESLint 8+ then I suppose we also automatically inherit its engines requirement. As long as this plugin works wherever the underlying ESLint versions we support work, I think we're good there. |
I've updated the readme to refer to ESLint 8+. I've also updated the devdep range for ESLint to from ^8 to >=8. This makes CI more brittle, but I think it's more important to learn about breaking changes in ESLint 9+. |
And I just added Node 18 to the CI matrix. I think this is ready to go. I'll merge it, and then release 4.0.0. |
ref sveltejs/kit#4553