Skip to content

fix(create-svelte): bump minimum required Svelte version #1192

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Apr 29, 2021

Conversation

dummdidumm
Copy link
Member

The Vite Svelte plugin uses the cssHash option which was added in 3.34

For some reason I can't build the templates locally, it says

import { transform } from 'sucrase';
         ^^^^^^^^^
SyntaxError: The requested module 'sucrase' is expected to be of type CommonJS, which does not support named exports. CommonJS modules can be imported by importing the default export.

So I hope I got the right place where to bump the version

The Vite Svelte plugin uses the cssHash option which was added in 3.34
@Conduitry
Copy link
Member

What version of Node are you on when you're trying to build this locally? I think later versions got better at CJS/ESM interop in areas like this. See also the comment #1000 (comment) on that closed PR.

@benmccann benmccann merged commit d19f3de into master Apr 29, 2021
@benmccann benmccann deleted the create-svelte-bump-svelte branch April 29, 2021 00:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants