Skip to content

exclude deploy artifacts from create-svelte #1363

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
May 6, 2021
Merged

Conversation

Rich-Harris
Copy link
Member

not a huge deal since we release via an action, but when i built this package locally it included the contents of .cloudflare. No harm in guarding against that happening during a manual release

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

@Conduitry
Copy link
Member

Is this the .gitignore that ends up in users' projects, or is it used in deciding what gets published in the create-svelte package itself? I know there was something weird about npm publish renaming a file transparently.

If it's the latter, I'd probably prefer an explicit whitelist approach (with pkg.files) for what ends up in the package.

@Rich-Harris
Copy link
Member Author

It's the latter. Whitelist is probably smarter, but would require some implementing, and I figured this quick fix is better than nothing in the meantime

Copy link
Member

@Conduitry Conduitry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 That's fair. Sounds good to me.

@Rich-Harris Rich-Harris merged commit 8a402a9 into master May 6, 2021
@Rich-Harris Rich-Harris deleted the ignore-deploy-files branch May 6, 2021 20:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants