Skip to content

Squelch rollup warnings #13687

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Apr 8, 2025
Merged

Squelch rollup warnings #13687

merged 3 commits into from
Apr 8, 2025

Conversation

Rich-Harris
Copy link
Member

Rollup is quite aggressive about warning on missing imports — if you have something this...

import * as foo from './foo.js';

if (foo.bar) {
  foo.bar();
}

...it will yell at you if foo.js doesn't export bar. This is a useful warning, unless the import is in code the user doesn't control, such as the generated app.js referencing client_hooks.handleError (which is known to be harmless).

This PR squelches those warnings.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Apr 7, 2025

🦋 Changeset detected

Latest commit: c8ec08e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

@eltigerchino eltigerchino merged commit dd5381a into main Apr 8, 2025
18 checks passed
@eltigerchino eltigerchino deleted the squelch-rollup-warnings branch April 8, 2025 07:54
@github-actions github-actions bot mentioned this pull request Apr 8, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants