Skip to content

Replace favicon #1589

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
May 29, 2021
Merged

Replace favicon #1589

merged 3 commits into from
May 29, 2021

Conversation

Rich-Harris
Copy link
Member

Updates the favicon to use the same one as in the existing Sapper/Svelte templates

  • contains the Svelte logo but with gray, not orange, which better communicates 'placeholder'
  • favicons should be a minimum of 32x32 (not 16x16, despite a surprising amount of bad information on the internet) because retina

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

@Rich-Harris Rich-Harris merged commit 6aa4988 into master May 29, 2021
@Rich-Harris Rich-Harris deleted the replace-favicon branch May 29, 2021 20:47
sidharthv96 added a commit to sidharthv96/kit that referenced this pull request May 30, 2021
…r/cutomExtensionTest

* 'master' of https://github.com/sveltejs/kit:
  fix: append trailing slash in manifest (sveltejs#1507)
  Version Packages (next) (sveltejs#1590)
  Rename `handle`'s `render` parameter to `resolve` (sveltejs#1566)
  Replace favicon (sveltejs#1589)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant