Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: use path/posix to resolve relative paths #3212

Merged
merged 4 commits into from
Jan 5, 2022
Merged

fix: use path/posix to resolve relative paths #3212

merged 4 commits into from
Jan 5, 2022

Conversation

hyunbinseo
Copy link
Contributor

Fixes #3211

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Jan 5, 2022

🦋 Changeset detected

Latest commit: 99f7090

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-cloudflare-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jan 5, 2022

✔️ Deploy Preview for kit-demo canceled.

🔨 Explore the source changes: 99f7090

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61d50a9faf2e500008b8c52c

@Conduitry
Copy link
Member

path/posix wasn't added until Node 15.3.0. We want to support back to Node 14.13, so this should use the import { posix } from 'path' syntax that was used in #3200.

@ignatiusmb ignatiusmb merged commit a4402c4 into sveltejs:master Jan 5, 2022
@github-actions github-actions bot mentioned this pull request Jan 5, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adapter-cloudflare-workers build fails in Windows (could not resolve)
3 participants