Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[chore] update vite and esbuild #3791

Merged

Conversation

dominikg
Copy link
Member

@dominikg dominikg commented Feb 9, 2022

update to vite 2.8, esbuild 0.14 and ts 4.5

a test in sveltekit package fails due to the new .m.ts files created from .mjs sources.
docs: https://discord.com/channels/457912077277855764/571775594002513921/940924260833185794

cc @dummdidumm

related: #3064 should we add that flag here or afterwards in a separate PR?

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2022

🦋 Changeset detected

Latest commit: 90b9555

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@sveltejs/adapter-cloudflare Patch
@sveltejs/adapter-cloudflare-workers Patch
@sveltejs/adapter-netlify Patch
@sveltejs/adapter-vercel Patch
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dominikg dominikg changed the title Chore/update vite esbuild typescript [chore] update vite esbuild typescript Feb 9, 2022
@dominikg
Copy link
Member Author

dominikg commented Feb 9, 2022

maybe related to the packaging .mts fail: #3783

@dominikg dominikg changed the title [chore] update vite esbuild typescript [chore] update vite esbuild Feb 9, 2022
@dominikg
Copy link
Member Author

dominikg commented Feb 9, 2022

keep typescript at 4.4 for now as suggested by @benmccann , 4.5 update can be done separately later, see problems above

@benmccann benmccann changed the title [chore] update vite esbuild [chore] update vite and esbuild Feb 9, 2022
@netlify
Copy link

netlify bot commented Feb 9, 2022

✔️ Deploy Preview for kit-demo canceled.

🔨 Explore the source changes: 90b9555

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/6203db7e687c0a00082cc4f0

@benmccann benmccann merged commit b33f75a into sveltejs:master Feb 9, 2022
@github-actions github-actions bot mentioned this pull request Feb 9, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants