Skip to content

remove unnecessary units #4115

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Feb 24, 2022
Merged

remove unnecessary units #4115

merged 2 commits into from
Feb 24, 2022

Conversation

icecream17
Copy link
Contributor

@icecream17 icecream17 commented Feb 24, 2022

This is extremely minor so I haven't filled in most of the checklist

Changes 0px 0px to 0 0

Using units after 0 causes a lint warning in vscode, css(zeroUnits), and also it's consistent with the omission in margin: 0 0 0.5rem 0

There are some cases in calc where units are required, but this doesn't apply since the change is in drop-shadow

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Feb 24, 2022

🦋 Changeset detected

Latest commit: 7b2bd6f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

thanks!

@Rich-Harris Rich-Harris merged commit 09bf92f into sveltejs:master Feb 24, 2022
@icecream17 icecream17 deleted the patch-1 branch February 24, 2022 18:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants