Skip to content

[chore] specify engines.node version in templates #5096

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 2 commits into from

Conversation

metonym
Copy link
Contributor

@metonym metonym commented May 27, 2022

Follow-up to #5062

SvelteKit now requires Node >=16.7. It would be a nice for this to be explicitly specified via engines.node in the package.json.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented May 27, 2022

🦋 Changeset detected

Latest commit: 5371aa7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
default-template Patch
create-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Conduitry
Copy link
Member

Hm, has the behavior I mentioned here changed since then?

@Rich-Harris
Copy link
Member

It's listed in Kit's package.json:

"engines": {
"node": ">=16.7"
}

I'm pretty sure adding it to the app template won't change anything, so I'll close this

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants