Skip to content

reorder create-svelte templates such that library is last * libskeleton was renamed to skeletonlib #6481

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

braebo
Copy link
Member

@braebo braebo commented Aug 31, 2022

  • libskeleton was renamed to skeletonlib

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs

closes #6470

  • This message body should clearly illustrate what problems it solves.

I've been seeing reports of users mistakenly choosing "Library skeleton project" because it's 2nd on the list in create-svelte, resulting in confusion. Moving it to be 3rd should help people avoid this mistake.

  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

* `libskeleton` was renamed to `skeletonlib`
@changeset-bot
Copy link

changeset-bot bot commented Aug 31, 2022

🦋 Changeset detected

Latest commit: f9f79d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could arguably come up with something a little more robust, but I'm happy enough with this for now. I'll leave it for the other maintainers in case they feel differently though

@Rich-Harris
Copy link
Member

what ben said

@braebo
Copy link
Member Author

braebo commented Aug 31, 2022

Yea perhaps adding an "order" field to the template metadata file.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorder "Library skeleton project" to 3rd in the list for create-svelte
3 participants