Skip to content

Fix sverdle form reset #7241

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Oct 12, 2022
Merged

Fix sverdle form reset #7241

merged 3 commits into from
Oct 12, 2022

Conversation

eltigerchino
Copy link
Member

fixes #7238
provides a custom form enhance callback for the demo app /sverdle to prevent form.reset() being called by the default callback.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2022

🦋 Changeset detected

Latest commit: 9b8d9f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rescribet
Copy link

rescribet commented Oct 12, 2022

Can confirm this fixing the game, thanks!

Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com>
@dummdidumm dummdidumm merged commit 78becbb into sveltejs:master Oct 12, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sverdle guesses not visible using JS
4 participants