Skip to content

Direct user to publish ./package/ directory instead of ./ #7280

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
Oct 17, 2022

Conversation

brev
Copy link
Contributor

@brev brev commented Oct 17, 2022

After running svelte-package (via create-svelte), the user is supposed to
run: npm publish package/. However, it is easy to accidentally run
npm publish on the wrong directory out of habit. With this change,
when the user accidentally tries to publish the ./ directory, they will be
directed to publish the ./package/ directory instead.

In case it is useful, thanks.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

brev added 2 commits October 16, 2022 18:14
…posed to

run: `npm publish package/`. However, I keep accidentally running `npm publish`
(the wrong directory) out of habit, instead.
With this change, when the user accidentally tries to publish the `./`
directory, they will be directed to publish the `./package/` directory instead.
@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2022

🦋 Changeset detected

Latest commit: eed3a68

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants