Skip to content

fix(create-svelte): add hint when scaffolding #9318

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Mar 5, 2023

Conversation

theetrain
Copy link
Contributor

Relates to #9317

A number of folks on Discord have been asking how to toggle options in the new 'Select additional options' step when running npm create svelte@latest. This change aims to provide a hint for this lesser-known prompt experience.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@@ -77,7 +77,7 @@ const options = await p.group(

features: () =>
p.multiselect({
message: 'Select additional options',
message: 'Select additional options (use arrow keys to navigate and SPACE to toggle options)',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make it a little shorter, so that it's less likely to break onto two lines?

Suggested change
message: 'Select additional options (use arrow keys to navigate and SPACE to toggle options)',
message: 'Select additional options (use arrow keys/space bar)',

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me 👍

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants