Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(vscode): let linkedEditing work when tag name contains . #2570

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

dyc3
Copy link
Contributor

@dyc3 dyc3 commented Nov 7, 2024

fixes #2569

Tested it manually on my machine and it works.

@jasonlyu123
Copy link
Member

What I meant is to copy this regex to HTMLPlugin, tweak it and return it with the link editing result ranges. https://github.com/sveltejs/language-tools/blob/master/packages/language-server/src/plugins/html/HTMLPlugin.ts#L320. This way only the linked editing get the override and it won't affect other features.

@dyc3
Copy link
Contributor Author

dyc3 commented Nov 7, 2024

Ah, my bad, I misunderstood. Will fix.

@dyc3 dyc3 force-pushed the fix-linked-editing-w-dot branch from 7075ec5 to e56c5b0 Compare November 7, 2024 14:27
@dyc3
Copy link
Contributor Author

dyc3 commented Nov 7, 2024

Should be good now. Tested it manually again and it works.

@dyc3 dyc3 force-pushed the fix-linked-editing-w-dot branch 2 times, most recently from 1cf8d88 to 88660a3 Compare November 7, 2024 23:23
@dyc3 dyc3 force-pushed the fix-linked-editing-w-dot branch from 88660a3 to 20ba8f3 Compare November 7, 2024 23:52
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@dummdidumm dummdidumm merged commit a3a6393 into sveltejs:master Nov 8, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VSCode: editor.linkedEditing does not work when the tag contains .
3 participants