Skip to content

feat: support for use: directive parameter type #325

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Apr 26, 2023
Merged

feat: support for use: directive parameter type #325

merged 2 commits into from
Apr 26, 2023

Conversation

ota-meshi
Copy link
Member

@ota-meshi ota-meshi commented Apr 25, 2023

This PR improves assigning the correct type to use: directive parameters.

Related to sveltejs/eslint-plugin-svelte#442

@changeset-bot
Copy link

changeset-bot bot commented Apr 25, 2023

🦋 Changeset detected

Latest commit: 4b403ec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte-eslint-parser Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

coveralls commented Apr 25, 2023

Pull Request Test Coverage Report for Build 4793796590

  • 17 of 18 (94.44%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 90.76%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/context/script-let.ts 17 18 94.44%
Totals Coverage Status
Change from base Build 4792759535: 0.1%
Covered Lines: 2099
Relevant Lines: 2237

💛 - Coveralls

@sidharthv96
Copy link

That was super quick! Thank you ❤️

@ota-meshi ota-meshi merged commit 36b01ec into main Apr 26, 2023
@ota-meshi ota-meshi deleted the ts-use branch April 26, 2023 00:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants