Skip to content

feat!: drop support for old node versions (<18, 19, 21) #579

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

ota-meshi
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented Oct 20, 2024

🦋 Changeset detected

Latest commit: 6fa9135

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte-eslint-parser Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

coveralls commented Oct 20, 2024

Pull Request Test Coverage Report for Build 11430638886

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.913%

Totals Coverage Status
Change from base Build 11430272515: 0.0%
Covered Lines: 3000
Relevant Lines: 3218

💛 - Coveralls

@ota-meshi ota-meshi merged commit 4ac8236 into main Oct 21, 2024
12 checks passed
@ota-meshi ota-meshi deleted the drop-old-node branch October 21, 2024 08:24
@@ -12,7 +12,7 @@
"license": "MIT",
"packageManager": "pnpm@7.33.7",
"engines": {
"node": "^12.22.0 || ^14.17.0 || >=16.0.0"
"node": "^18.20.4 || ^20.18.0 || >=22.10.0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why >=22.10.0?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think because we need require(esm).

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants