fix: resolved issue of $props incorrectly detected as store when using variables named after runes like $props and props
#692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b2abfa0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
baseballyama
changed the title
$props was incorrectly recognized as astore when variables shared names with runes, such as $props and props.$props was incorrectly recognized as astore when variables shared names with runes, such as $props and props
Try the Instant Preview in Online PlaygroundInstall the Instant Preview to Your LocalPublished Instant Preview Packages:
|
baseballyama
changed the title
$props was incorrectly recognized as astore when variables shared names with runes, such as $props and props$props incorrectly detected as store when using variables named after runes like $props and props
baseballyama
force-pushed
the
fix/runes-scope
branch
from
e7f4446 to
6526483
Compare
… store when variables shared names with runes, such as `$props` and `props`.
baseballyama
force-pushed
the
fix/runes-scope
branch
from
6526483 to
b2abfa0
Compare
Pull Request Test Coverage Report for Build 14086358686Details
💛 - Coveralls |
|
I confirmed this PR fixes both issues in my project. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: sveltejs/eslint-plugin-svelte#1159
close: sveltejs/eslint-plugin-svelte#1158