Skip to content

fix: crash with $derived() in template using ts #698

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Apr 3, 2025

Conversation

ota-meshi
Copy link
Member

fixes #697

Copy link

changeset-bot bot commented Apr 3, 2025

🦋 Changeset detected

Latest commit: 8d3706b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte-eslint-parser Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 3, 2025

Try the Instant Preview in Online Playground

ESLint Online Playground

Install the Instant Preview to Your Local

npm i https://pkg.pr.new/svelte-eslint-parser@8d3706b

Published Instant Preview Packages:

View Commit

@coveralls
Copy link

coveralls commented Apr 3, 2025

Pull Request Test Coverage Report for Build 14237666721

Details

  • 21 of 21 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 94.668%

Totals Coverage Status
Change from base Build 14183694884: 0.007%
Covered Lines: 10491
Relevant Lines: 10958

💛 - Coveralls

Copy link
Member

@baseballyama baseballyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is very difficult to anticipate beforehand that $derived will be declared in the template section.😇

@baseballyama baseballyama merged commit 8188302 into main Apr 3, 2025
12 checks passed
@baseballyama baseballyama deleted the fix-function-bind-with-ts branch April 3, 2025 09:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using $derived in bind:value function binding setter yeilds parsing error
3 participants