fix: hydrate href that is part of spread attributes (#15226)

We had some duplicated and buggy code, removing it fixes #15120
sveltejs · Feb 6, 2025 · 4883fd2 · 4883fd2
1 parent f2c83e5
commit 4883fd2
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/.changeset/wicked-apes-sin.md b/.changeset/wicked-apes-sin.md
@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: hydrate `href` that is part of spread attributes
diff --git a/packages/svelte/src/internal/client/dom/elements/attributes.js b/packages/svelte/src/internal/client/dom/elements/attributes.js
@@ -419,11 +419,7 @@ export function set_attributes(
 				// @ts-ignore
 				element[name] = value;
 			} else if (typeof value !== 'function') {
-				if (hydrating && (name === 'src' || name === 'href' || name === 'srcset')) {
-					if (!skip_warning) check_src_in_dev_hydration(element, name, value ?? '');
-				} else {
-					set_attribute(element, name, value);
-				}
+				set_attribute(element, name, value);
 			}
 		}
 		if (key === 'style' && '__styles' in element) {

diff --git a/packages/svelte/tests/hydration/samples/repair-mismatched-a-href/_expected.html b/packages/svelte/tests/hydration/samples/repair-mismatched-a-href/_expected.html
@@ -1 +1 @@
-<!--[--><a href="/foo">foo</a><!--]-->
+<!--[--><a href="/foo">foo</a> <a href="/foo">foo</a><!--]-->
diff --git a/packages/svelte/tests/hydration/samples/repair-mismatched-a-href/main.svelte b/packages/svelte/tests/hydration/samples/repair-mismatched-a-href/main.svelte
@@ -3,3 +3,4 @@
 </script>
 
 <a href={browser ? '/foo' : '/bar'}>foo</a>
+<a {...{href: browser ? '/foo' : '/bar'}}>foo</a>
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		<!--[--><a href="/foo">foo</a><!--]-->
		<!--[--><a href="/foo">foo</a> <a href="/foo">foo</a><!--]-->
Original file line number	Diff line number	Diff line change
Expand Up		@@ -3,3 +3,4 @@
		</script>

		<a href={browser ? '/foo' : '/bar'}>foo</a>
		<a {...{href: browser ? '/foo' : '/bar'}}>foo</a>