Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: optimise || expressions in template #15092

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

Rich-Harris
Copy link
Member

small follow-up to #15056 — we can simplify the logic a tiny bit (and avoid mutating the AST node), but more to the point we can apply the same optimisation to || expressions. ultimately it would be nice to extend this to more cases (variables with a known set of possible values, ternaries, etc) but for now just picking the lowest-hanging fruit

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jan 22, 2025

🦋 Changeset detected

Latest commit: 9b39410

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15092

@Rich-Harris Rich-Harris merged commit 7740d45 into main Jan 22, 2025
11 checks passed
@Rich-Harris Rich-Harris deleted the optimise-or-expression branch January 22, 2025 20:48
This was referenced Jan 22, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants