Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: encounter svelte:element in blocks as sibling during pruning css #15165

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

7nik
Copy link
Contributor

@7nik 7nik commented Jan 31, 2025

Fixes #14890

I wonder whether loop_child should also return SlotElement and RenderTag like does get_possible_element_siblings. I couldn't comprehend or make up a case which requires it but fails.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jan 31, 2025

🦋 Changeset detected

Latest commit: 8b59da5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15165

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@dummdidumm dummdidumm merged commit 5b30fbf into sveltejs:main Feb 3, 2025
9 checks passed
@github-actions github-actions bot mentioned this pull request Feb 3, 2025
@7nik 7nik deleted the fix-14890 branch February 3, 2025 09:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS + combinator not applied to svelte:elements in #each loop
2 participants