Skip to content

fix: correctly validate head snippets on the server #15755

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Apr 13, 2025

Conversation

paoloricciuti
Copy link
Member

Closes #15753

We could've changed the validation to use something else in case of head but i thought it would've been nicer to just refactor the head payload to be a class too (also with a nice clone method) so we could check instanceof.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Apr 13, 2025

🦋 Changeset detected

Latest commit: 4f121e3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15755

@paoloricciuti paoloricciuti merged commit fd0bc29 into main Apr 13, 2025
13 checks passed
@paoloricciuti paoloricciuti deleted the head-snippet-server-validation branch April 13, 2025 10:20
@github-actions github-actions bot mentioned this pull request Apr 13, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

{@render ...} inside <svelte:head> causes "invalid_snippet_arguments" error
2 participants