Skip to content

fix: improve hydration of altered html #16226

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: improve hydration of altered html #16226

wants to merge 3 commits into from

Conversation

7nik
Copy link
Contributor

@7nik 7nik commented Jun 24, 2025

Closes #15337

Add checks that during hydration we retrieve a right node (should also we check nodeName?) and that we didn't cross the hydration marker.
Also, in case of hydration mismatch in svelte:head, remounts only the head instead of the entire app.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jun 24, 2025

🦋 Changeset detected

Latest commit: 5545894

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@16226

@7nik
Copy link
Contributor Author

7nik commented Jun 26, 2025

Having #16248, now I wonder if this PR makes sense. Though, I think remounting only the svelte:head is a good thing.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing to set <svelte:head> element with getAttribute is not a function
1 participant